MLH-Fellowship / explorer-portfolio-batch2

Jekyll portfolio website template to showcase your work using GitHub Pages
https://mlh-fellowship.github.io/portfolio-template/
MIT License
46 stars 121 forks source link

Add GitHub Action to make sure the PRs build successfully #17

Open wrussell1999 opened 3 years ago

wrussell1999 commented 3 years ago

Add GitHub Action to make sure jekyll build builds successfully.

Bonus:

felixfaisal commented 3 years ago

Hey @wrussell1999 when you say doesn't contain their configuration, you mean that the original configuration should not be tampered with?

wrussell1999 commented 3 years ago

Hey @felixfaisal!

Basically just check that their pull request doesn't contain anything that's unique to their template like their experience, or photo etc so the template remains the same. If it detects these things, it fails the test.

These are (but not limited to):

Feel free to let me know if you think of anything else

felixfaisal commented 3 years ago

@wrussell1999 I will work on this issue

wrussell1999 commented 3 years ago

Excellent! Let me know if you need a hand :D @felixfaisal