MLH-Fellowship / explorer-portfolio-batch2

Jekyll portfolio website template to showcase your work using GitHub Pages
https://mlh-fellowship.github.io/portfolio-template/
MIT License
46 stars 121 forks source link

Add Github / Netlify Actions to deploy PRs #40

Open Korusuke opened 3 years ago

Korusuke commented 3 years ago

It would be great to deploy PRs so that it's easy to review / test them, this deployments links can be commented in the PR itself.

https://docs.netlify.com/site-deploys/notifications/#github-pull-request-comments

wrussell1999 commented 3 years ago

I actually added Netlify this morning! There’s one issue though: it breaks because of the github pages site being hosted on /portfolio-site

jkmartindale commented 3 years ago

There’s one issue though: it breaks because of the github pages site being hosted on /portfolio-site

If it helps, I got a working deployment at https://agitated-davinci-5178e1.netlify.app/ with a corresponding netlify.toml. My build config does 3 things: