Closed amalaabraham closed 3 years ago
Thanks for the PR! I personally am a fan of shadow cards!
Two things:
I tested the PR and not all cards are showing the shadow, please check it out:
Can we add this to a variable so if someone doesn't want shadow cards, it can be turned off?
Check above comment
Hey @Korusuke
Resolved requested changes :)
Love it!
2 last things:
Thanks a lot! :)
Love it!
2 last things:
- Solve the conflicts so we can get this merged
- If possible can we have the clickable cards increase shadow when hovered (optional) (maybe a new PR, maybe in this)
Thanks a lot! :)
Thank you @Korusuke :) Resolved conflicts. Thank you for the suggestions and will make a separate PR for the same.
fixes #11
Changes
Even though the site is responsive, but it does not look good on a small screen. To make it more mobile-friendly, especially for the advantage of small screens, we can add a breakpoint where certain parts of the design will behave differently on each side of the breakpoint. Media queries can help with that. Also, the shadowbox effect has been added so to make it visually appealing and distinguish the geometry.
Screenshots
Before
After
Mentions
@wrussell1999 , @Korusuke Please go through the changes
Types of changes
Checklist