MLH-Fellowship / explorer-portfolio-batch2

Jekyll portfolio website template to showcase your work using GitHub Pages
https://mlh-fellowship.github.io/portfolio-template/
MIT License
46 stars 121 forks source link

add shadow to cards and style fixes to improve usability on mobile. #52

Closed amalaabraham closed 3 years ago

amalaabraham commented 3 years ago

fixes #11

Changes

Even though the site is responsive, but it does not look good on a small screen. To make it more mobile-friendly, especially for the advantage of small screens, we can add a breakpoint where certain parts of the design will behave differently on each side of the breakpoint. Media queries can help with that. Also, the shadowbox effect has been added so to make it visually appealing and distinguish the geometry.

Screenshots

Before

mlh1

After

mlh2

Mentions

@wrussell1999 , @Korusuke Please go through the changes

Types of changes

Checklist

Korusuke commented 3 years ago

Thanks for the PR! I personally am a fan of shadow cards!

Two things:

amalaabraham commented 3 years ago

Check above comment

Hey @Korusuke

Resolved requested changes :)

Korusuke commented 3 years ago

Love it!

2 last things:

Thanks a lot! :)

amalaabraham commented 3 years ago

Love it!

2 last things:

  • Solve the conflicts so we can get this merged
  • If possible can we have the clickable cards increase shadow when hovered (optional) (maybe a new PR, maybe in this)

Thanks a lot! :)

Thank you @Korusuke :) Resolved conflicts. Thank you for the suggestions and will make a separate PR for the same.