MLH-Fellowship / explorer-portfolio-batch2

Jekyll portfolio website template to showcase your work using GitHub Pages
https://mlh-fellowship.github.io/portfolio-template/
MIT License
46 stars 121 forks source link

fixed minor accessibility issues #69

Open sakshigupta265 opened 3 years ago

sakshigupta265 commented 3 years ago

Changes

The changes are made to fix issue #62 The website had minor accessibility issues like:

How Has This Been Tested?

The proposed changes were tested on the local computer, and a performance was checked using chrome lighthouse

Mentions

@Korusuke, kindly review the changes

Types of changes

Checklist

sakshigupta265 commented 3 years ago

Very small fix I'd like to see that isn't your fault, but will need to be fixed here since you're editing the line already:

{{ site.url }} isn't the right way to make absolute URLs in Jekyll. It works some of the time but can break. The proper way is to use {{ '/cv/resume.pdf' | absolute_url }}, which will work in all cases.

Thanks for the updates

sakshigupta265 commented 3 years ago

@Korusuke, please review it. Thanks