MLH-Fellowship / explorer-portfolio-batch2

Jekyll portfolio website template to showcase your work using GitHub Pages
https://mlh-fellowship.github.io/portfolio-template/
MIT License
46 stars 121 forks source link

Google Analytics Support #71

Closed saksham1991999 closed 3 years ago

saksham1991999 commented 3 years ago

Changes

Added a on-page Global Site Tag (gtag.js) for Google Analytics Support configurable from _config.yml.

How Has This Been Tested?

Created our own Measurement ID and added the on-page tag to header.js along with the Measurement ID confidurable from config.js

Checked the source code on live server and matched the tag with the instructions provided from Google Analytics. Also was able to track the views on my Google Analytics dashboard successfully.

Our change doesn't affects other areas of code.

Mentions

@prabalchhatkuli and @MyatThuKo

Types of changes

Checklist

MyatThuKo commented 3 years ago

Changes

Added an on-page Global Site Tag (gtag.js) for Google Analytics Support configurable from _config.yml.

How Has This Been Tested?

First, I installed the Ruby version to my MacBook by following this stackoverflow. I used rbenv to set up a Ruby environment to test locally on my MacBook.

As Saksham mentioned above, we used our own Measurement ID to test out the tracking on the Google Analytics Website.

Our code does not have any effect on other code base and does not have any conflicts.

Mentions

@saksham1991999 and @prabalchhatkuli

Types of changes

Checklist

Korusuke commented 3 years ago

Thanks a lot for this PR! Closes #48

Korusuke commented 3 years ago

when a PR is addressed to an issue we usually write something like fixes, closes, resolve and pr number. For example: Resolves #48 so that the issue is automagically closed when/if the PR is merged, just something to keep in mind for next time :)