MLH-Fellowship / explorer-portfolio-batch2

Jekyll portfolio website template to showcase your work using GitHub Pages
https://mlh-fellowship.github.io/portfolio-template/
MIT License
46 stars 121 forks source link

Dark Mode for subpages #76

Open ShrillShrestha opened 3 years ago

ShrillShrestha commented 3 years ago

Changes

Dark mode for subpages. Continuation for #55

How Has This Been Tested?

I tested the changes locally in the chrome browser for mac.

Mentions

@RashikaKarki, @wrussell1999, @Korusuke Also, right now the subpages don't inherit dark mode from the home page (they have their own toggle button). I am trying to make it inherit to subpages. So, if you have any advice/ tips on how I can make that happen, I am happy to hear them.

Types of changes

Checklist

ShrillShrestha commented 3 years ago

@Korusuke, the dark mode is acting weird. @RashikaKarki tried checking the dark mode, and the subpages were inheriting the dark mode. But I tried on my browser and it looks like it's not working. I am not sure if it's because we are using different systems. I am using macOS, and Rashika is using Windows. We also tried every browser(Chrome, Mozilla,...) we have. Do you have any suggestions on what I should be doing next?