MLH-Fellowship / march-2022-prep-portfolio

Portfolio for March 2022 Prep
https://prep-march-2022.netlify.app
MIT License
2 stars 16 forks source link

added footer to website #19

Closed Chibi-girl closed 2 years ago

Chibi-girl commented 2 years ago

Please, go through these steps before you submit a PR.

This pull request adds a footer to the both the home page as well as the project page. The footer contains links to blog, about, home, socials etc., which has been linked to the home page for now, and a link to the project page.

This was done by adding footer.html in the index.html file(for the main page), and adding footer.html in the page.html file of _layouts directory(for the project page). Corresponding css was added in the _sass directory, and necessary bootstrap scripts were added in the header file. The bottom margin for body was also set to zero in all.scss in order to remove any unnecessary whitespace below the footer.

Adding a footer is important because any website is incomplete without a footer, which serves to provide quick links to all the pages of the website/ socials of the website owner in one place, hence increasing ease of access.

Here's how the footer looks for the main page as well as the project page across different dimensions:

dim_large

dim_med

dim_small

netlify[bot] commented 2 years ago

✔️ Deploy Preview for prep-march-2022 ready!

🔨 Explore the source changes: 514150c9d8455809e17773639b6285a39b082eb1

🔍 Inspect the deploy log: https://app.netlify.com/sites/prep-march-2022/deploys/6229cd9ab0ed51000947ab30

😎 Browse the preview: https://deploy-preview-19--prep-march-2022.netlify.app