search

MLH-Fellowship / march-2022-prep-portfolio

Portfolio for March 2022 Prep
https://prep-march-2022.netlify.app
MIT License
2 stars 16 forks source link

Added social icons to the fellow cards #20

Closed AJgthb2002 closed 2 years ago

AJgthb2002 commented 2 years ago

Please, go through these steps before you submit a PR.

Resolves Issue #11 This pull request adds icons of social profiles like GitHub, LinkedIn, Twitter and Resume icon to the fellow cards. This was done by modifying the description.html file: Added a div with class "socials" below the div having class "info", inside the card. Added the social icons inside this "socials" div.

The corresponding CSS was also added in all.scss file

Adding the social profile icons will help people connect with the fellows easily. It will encourage networking.

Here's how the cards look across different dimensions:

image image image
netlify[bot] commented 2 years ago

✔️ Deploy Preview for prep-march-2022 ready!

🔨 Explore the source changes: 3db9433f1558fc08df54168c31a17ccbec8a4bf8

🔍 Inspect the deploy log: https://app.netlify.com/sites/prep-march-2022/deploys/622af3e379e0000008b09dac

😎 Browse the preview: https://deploy-preview-20--prep-march-2022.netlify.app/

AJgthb2002 commented 2 years ago

@marcnjaramillo I had created this PR yesterday when issue #12 was yet to be fixed. Now that you have merged the PR that solves this issue, cards will not overlap with the images on a mobile screen. I checked the deployment preview, looks fine to me.

I'll update the screenshots!

marcnjaramillo commented 2 years ago

I see. I just checked it myself and saw that too. Thanks for replying!