search

MLH-Fellowship / march-2022-prep-portfolio

Portfolio for March 2022 Prep
https://prep-march-2022.netlify.app
MIT License
2 stars 16 forks source link

Image Action in order to compress image for performance #23

Closed Minh-ctrl closed 2 years ago

Minh-ctrl commented 2 years ago

✅ Closes: #2 Please, go through these steps before you submit a PR. [X] My Pod Leader knows I'm working on this Pull Request [X] I've explained what the Pull Request is adding. [X] I've explained why this is important.

I've done some research and found about Image Action which helps with image compression for better performance. the yml script i've included will run during the pull request CI workflow. github actions bot will also send a report of the compression as well as a visual difference between uncompressed and compressed version, both of which is included in these screenshots below.

image image
netlify[bot] commented 2 years ago

✔️ Deploy Preview for prep-march-2022 ready!

🔨 Explore the source changes: 88530e71df00582146b9aeb1fa6be985f875ed16

🔍 Inspect the deploy log: https://app.netlify.com/sites/prep-march-2022/deploys/622a63e1786b700008789f9a

😎 Browse the preview: https://deploy-preview-23--prep-march-2022.netlify.app

marcnjaramillo commented 2 years ago

This is great work, Minh! I'm glad you were able to learn more about and implement some GitHub Actions for this.