Improve profile layout - Githubissues

MLH-Fellowship / march-2022-prep-portfolio

Portfolio for March 2022 Prep

https://prep-march-2022.netlify.app

MIT License

2 stars 16 forks source link

Improve profile layout #27

Open Hanaffi opened 2 years ago

Hanaffi commented 2 years ago

Please, go through these steps before you submit a PR.

[x] My Pod Leader knows I'm working on this Pull Request
[X] I've explained what the Pull Request is adding.
[x] I've explained why this is important.

What I have done here:

Improved profile layout
Add header background
Fixed footer icons alignment

Some SS(s) below.

netlify[bot] commented 2 years ago

✔️ Deploy Preview for prep-march-2022 ready!

🔨 Explore the source changes: 7e21dd082069846de7ffa4a027b58ecb578a7bd1

🔍 Inspect the deploy log: https://app.netlify.com/sites/prep-march-2022/deploys/622ba700df39ee0008d715ec

😎 Browse the preview: https://deploy-preview-27--prep-march-2022.netlify.app

Minh-ctrl commented 2 years ago

Hey @Hanaffi, great job on that fix :)

I just wanted to echo the same thing @sohamsshah had helped me with this issue. From a design perspective perhaps it's better to have the images at a smaller size in order to have a 2x2 structure. As of now it takes a lot of scrolling to go through everyone's pictures in smaller screens. What do you think?

Hanaffi commented 2 years ago

@Minh-ctrl Well, I thought about removing the whole profile section for tiny screens in another PR. But lets go with your suggestion , Thanks :)