search

MLH-Fellowship / orientation-project-js-23.FAL.A

Orientation Project (JavaScript) for 23.FAL.A
1 stars 3 forks source link

Page for editing existing Skill #3

Open wrussell1999 opened 1 year ago

wrussell1999 commented 1 year ago

https://github.com/MLH-Fellowship/orientation-project-python/issues/17

jescalada commented 1 year ago

@wrussell1999

Question: Would it be acceptable to implement this as a component that gets appended dynamically to the DOM instead of making a separate page?

If the form is closed, it opens upon clicking Add Experience and shows it. If the form is already open, it validates and closes it (and updates the state to display the newly added experience).

Example (forgive the poor styling) image

jescalada commented 1 year ago

I just noticed that @MAMV3x3 is proposing using a modal to implement the Add Skill functionality in #9 . I may reuse the modal and add a button for editing instead in order to ensure consistency. I'll contact him in order to make sure our features make sense.

jescalada commented 12 months ago

In the end, I decided to implement the edit form as a button that is added to each entry. When pressed, it opens an editing form:

image

I feel this will be the most user-friendly option as they can edit multiple entries at the same time if required.

jescalada commented 12 months ago

Just added @sammychinedu2ky as I have accidentally completed the Edit Experience issue instead of the Edit Skill. 😅