search

MLH-Fellowship / orientation-project-python-23.SUM.B

Orientation Project (Python) for 23.SUM.B
1 stars 18 forks source link

add functionality to return the list of experiences #24

Closed david-wagih closed 1 year ago

david-wagih commented 1 year ago

Added small change actually in the method that runs at thr specified route with GET method that returns a list of all the experiences.

david-wagih commented 1 year ago

@fissoreg the test fails because they first test to add w new experience first before getting them back so my PR is just related to getting the list back not adding new one and the same for adding new education and skills

fissoreg commented 1 year ago

That makes sense, thank you @david-wagih!

I would suggest to wait for #22 to be merged, then you can rebase your changes on top of it so we can have the tests passing. Does that sound good?

You can go ahead with a new issue in the meanwhile :)

david-wagih commented 1 year ago

@fissoreg okay that sounds good 👍

david-wagih commented 1 year ago

@fissoreg I have fixed some errors and changes in this branch and now it has all the issues I worked on as this is my main branch, but there are 2 tests failing depending on those two issues which should be merged (the one for creating new education and the one for returning all education)

fissoreg commented 1 year ago

Hey @david-wagih ideally we would like to have each new functionality in its own branch. I will be happy to go ahead and merge your branch now, but there are some conflicts. Maybe you can look into that so we can close this up?

david-wagih commented 1 year ago

@fissoreg the branch has no conflicts now, so I think we can work on merging it