search

MLH-Fellowship / orientation-project-python-23.SUM.B

Orientation Project (Python) for 23.SUM.B
1 stars 18 forks source link

Return all skills functionality #29

Closed john-thuo1 closed 1 year ago

john-thuo1 commented 1 year ago

15 Return all skills functionality

john-thuo1 commented 1 year ago

@fissoreg , Some of the test cases are failing because the features for adding Education and Experience are yet to be implemented. I had also implemented this feature in my first pr together with the add skills functionality to ensure that the _testskill() test case worked. I had added this line on the GET method : jsonify(data["skill"])

fissoreg commented 1 year ago

Hey @john-thuo1 thank you for the PR! :) The code looks good but there are a couple of problems with the merge I think:

  1. I would expect this PR to include commits for the specific functionality only; it looks like you are also including commits from your previous PR (you probably didn't start a new branch for this specific functionality?)
  2. Would be great if you could use a more specific branch name than orient3 (e.g. return-all-skills).

Would you be able to start with a fresh branch from main and apply only the commits that relate to the issue at hand?