Created education get and post AND data persistence

MLH-Fellowship / orientation-project-python-24.SUM.A

Orientation Project (Python for 24.SUM.A)

2 stars 6 forks source link

Created education get and post AND data persistence #27

Closed andyjianzhou closed 3 months ago

andyjianzhou commented 3 months ago

Used dataclasses to deserialize and serialize data. This creates a layer between the application and the data.
Validated education class
Returns index of ID for education posts and returns all posts
running "?index=0" would retrieve the proper indexed education item
Fixed pytest to be more logical about ID
FOR THE FUTURE, maybe create mock test data
[x] Solves #18
[x] Solves #17

andyjianzhou commented 3 months ago

@Pradyuman7

andyjianzhou commented 3 months ago

@Pradyuman7 Added utility method. I looked over other people's post and get request. They're doing it correctly, really it's just loading the data and saving the data that needs to be changed (as I defined it in utilities). They can just accept my changes, and then accept their changes they made for their tasks. Should work seamlessly, as Joel also saves it via dataclass model

IvanKolchanov commented 3 months ago

By the way, we have 2 pytests failing because the change to POST /resume/education, which doesn't return missing fields now, causes the tests to fail :0. Just noticed that when posting a PR and wanted to say 👍

Pradyuman7 commented 3 months ago

By the way, we have 2 pytests failing because the change to POST /resume/education, which doesn't return missing fields now, causes the tests to fail :0. Just noticed that when posting a PR and wanted to say 👍

Nice Ivan, thanks for pointing this out, I have created #37 based on your comment. We can track it there