search

MLH-Fellowship / orientation-project-python-24.SUM.A

Orientation Project (Python for 24.SUM.A)
2 stars 6 forks source link

Andy/validation #28

Closed andyjianzhou closed 3 months ago

andyjianzhou commented 3 months ago
andyjianzhou commented 3 months ago

@Pradyuman7 Made it work with data persistence, and organized code in a way that there are repeating lines of code for each POST request (same process)

andyjianzhou commented 3 months ago

Made it work with new and improved testcase

Pradyuman7 commented 3 months ago

@Pradyuman7 Made it work with data persistence, and organized code in a way that there are repeating lines of code for each POST request (same process)

  • So I am thinking, because adding it to data.json is the same process, should I make a service/utility function to simply add it based off the API request name? Then, it will be very easy and we'll have a "service" layer to the codebase. Or is that an overkill in this case haha

I'd think an ovekill, but we could do it later as improvement

andyjianzhou commented 3 months ago

@Pradyuman7 Done! Ready for review