Closed shivamsouravjha closed 3 years ago
I'm trying to resolve the errors.
@shivamsouravjha are these resolved ?
@hkaur008 yes resolved!
@rosekamallove Idk why I'm getting this bug ,any clue about this?
Yeah, you don't really need to worry about it if it's not causing any problem in the functionality of your PR. I fixed it already in my PR yesterday. (Basically, @hkaur008 suggested I change the file location so I did it and fixed the src)
yeah yeah, I remember the suggestion thing, cool if it's fixed then.
Hey, whats the expected behaviour for this?
For me, it opens my email client and creates an example message
Put it buts the name and email in the content of the message.
How does the portfolio author change the email to be sent to ?
I think we just need to document the feature a bit better so it's clear what to expect from this change
@awilkescom so this feature is a way for the visitor to contact the portfolio owner, and yes this is the desired behaviour of the email. I will comment on the area from where we can change the email.
Ok, thanks!
What I've done:-
I've added a contact info form where the viewer can enter the name, mail, message and send an email to contact us. Why have I done:
In order to enable viewers to have conversations with the portfolio creators.
Please, go through these steps before you submit a PR.
[X] You've explained what the Pull Request is adding.
[X] You've explained why this is important.
Closes #5
CC @hkaur008 for review/suggestion.