MLH-Fellowship / pod-3.1.1-portfolio

MIT License
2 stars 9 forks source link

Contactinfo #24

Closed shivamsouravjha closed 3 years ago

shivamsouravjha commented 3 years ago

What I've done:-

Closes #5

CC @hkaur008 for review/suggestion.

shivamsouravjha commented 3 years ago

I'm trying to resolve the errors.

hkaur008 commented 3 years ago

@shivamsouravjha are these resolved ?

shivamsouravjha commented 3 years ago

@hkaur008 yes resolved!

shivamsouravjha commented 3 years ago

@rosekamallove Idk why I'm getting this bug ,any clue about this? Screenshot (276)

rosekamallove commented 3 years ago

Yeah, you don't really need to worry about it if it's not causing any problem in the functionality of your PR. I fixed it already in my PR yesterday. (Basically, @hkaur008 suggested I change the file location so I did it and fixed the src)

shivamsouravjha commented 3 years ago

yeah yeah, I remember the suggestion thing, cool if it's fixed then.

awilkescom commented 3 years ago

Hey, whats the expected behaviour for this?

For me, it opens my email client and creates an example message

Put it buts the name and email in the content of the message.

How does the portfolio author change the email to be sent to ?

I think we just need to document the feature a bit better so it's clear what to expect from this change

image

shivamsouravjha commented 3 years ago

@awilkescom so this feature is a way for the visitor to contact the portfolio owner, and yes this is the desired behaviour of the email. I will comment on the area from where we can change the email.

awilkescom commented 3 years ago

Ok, thanks!