Overflow & ID's for Data

gibbonhug commented 1 year ago

This pull request re-adds the overflow fixed in this pull request which was overridden in merge conflicts. This was part of Issue #12. This is important so we do not lose improvements made to our site.

I also added unique ID's as part of fellow data. This addresses Issue #50. This is important because it makes the map function smoothly, and for any future features, we have a way to easily refer to unique fellows. Prior to this the map code was relying on the name data to refer to individual fellows. Since some people entered both their first and last name with a space in-between, this broke the map functionality because individual fellows were parsed by spaces.

[x] My Pod Leader knows I'm working on this Pull Request
[x] I've explained what the Pull Request is adding.
[x] I've explained why this is important.

netlify[bot] commented 1 year ago

Deploy Preview for prep-22-jul-prep-3-portfolio ready!

Name	Link
Latest commit	ede366852fdd0875e9a29837afd059b66ea0bf7d
Latest deploy log	https://app.netlify.com/sites/prep-22-jul-prep-3-portfolio/deploys/62d1a95cc6124900086d5aa1
Deploy Preview	https://deploy-preview-51--prep-22-jul-prep-3-portfolio.netlify.app/
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

awilkescom commented 1 year ago

@gibbonhug @himanshu-thakur-7 can you please check in with each other, as I think Himanshu has a good point here.

gibbonhug commented 1 year ago

Sorry, I accidentally resolved the merge conflicts incorrectly the first time. I think it is fixed now.

Latest changes also delete a duplicate fellow from the data and an unnecessary dotfile.

MLH-Fellowship / prep-portfolio-22.JUL.PREP.3