added stats feature - Githubissues

MLH-Fellowship / prep-portfolio-23.MAR.PREP.2

MLH Prep Portfolio for Pod 23.MAR.PREP.2

https://mlh-prep-23-mar-prep-2-portfolio.netlify.app/

MIT License

4 stars 14 forks source link

added stats feature #16

Closed LycheeBay closed 1 year ago

LycheeBay commented 1 year ago

Please, go through these steps before you submit a PR.

[x] My Pod Leader knows I'm working on this Pull Request
[x] I've explained what the Pull Request is adding.
[x] I've explained why this is important.

netlify[bot] commented 1 year ago

Deploy Preview for mlh-prep-23-mar-prep-2-portfolio ready!

Name	Link
Latest commit	c6658c6ef3174536554e3b2df762fc62fcd1c944
Latest deploy log	https://app.netlify.com/sites/mlh-prep-23-mar-prep-2-portfolio/deploys/640928fec060c700085dcf20
Deploy Preview	https://deploy-preview-16--mlh-prep-23-mar-prep-2-portfolio.netlify.app/
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

utk09 commented 1 year ago

Wells -

The design is really cool. The hard work behind the CSS is really commendable. 👏🏼
The clever use of new JS utilities like Promise.all(), for-of construct, etc. is good.

Improves -

Code Splitting - It's important to separate the code so that the next person finds it easy to read. Example, the contributorsList can be taken out as a function and then can be used inside the Promise. ref - https://github.com/MLH-Fellowship/prep-portfolio-23.MAR.PREP.2/pull/16/commits/c6658c6ef3174536554e3b2df762fc62fcd1c944#diff-61def0c226ce2f96e27720bf43b7a239822732fa59ca003f3d30bd8f5a060128R26-R43

cc: @SandyCreek