search

MLH-Fellowship / prep-project-22.AUG.PREP.2

MLH Prep Project for Pod 22.JUL.AUG.2
https://prep-22-aug-prep-2-project.netlify.app/
MIT License
3 stars 13 forks source link

Add extra fields to weather card #64

Closed omeiirr closed 2 years ago

omeiirr commented 2 years ago

closes #39

Added the following fields to the weather card:

netlify[bot] commented 2 years ago

Deploy Preview for prep-22-aug-prep-2-project ready!

Name Link
Latest commit ee4f2396fb4d49c7b39c4c01c1f185c7dba337fb
Latest deploy log https://app.netlify.com/sites/prep-22-aug-prep-2-project/deploys/62fc763e0165d000086855f1
Deploy Preview https://deploy-preview-64--prep-22-aug-prep-2-project.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

omeiirr commented 2 years ago

Looks like this currently

image

keatonmartin commented 2 years ago

I like it a lot! The stats look great!

It does look like the item icons aren't centered vertically, which looks a little strange. Is it possible to center them?

farida52369 commented 2 years ago

Looks awesome .. and the changes in the files looks fine to me .. But as Keaton said .. if you're good at using CSS can you center the required items? .. i have noticed this problem especially in mobile mood .. but i made it hard coded as i wasn't able to solve it

ggongg commented 2 years ago

looks good

nightknighto commented 2 years ago

Been too long in opened state, so will merge, and those suggested updates can be made after in a new issue/pull request, and doesn't have to be strictly by omeir since we have no time.