search

MLH-Fellowship / prep-project-22.OCT.PREP.1

MLH Prep Project for Pod 22.OCT.PREP.1
https://prep-project-22-oct-1.netlify.app/
MIT License
2 stars 15 forks source link

Autocomplete or suggest cities based on user input #23

Closed Devansu-Yadav closed 1 year ago

Devansu-Yadav commented 1 year ago

This PR resolves #6 and makes the following changes:

netlify[bot] commented 1 year ago

Deploy Preview for prep-project-22-oct-1 ready!

Name Link
Latest commit 3b65ef6697b259c99ce4c94ddf7d180c04d57882
Latest deploy log https://app.netlify.com/sites/prep-project-22-oct-1/deploys/634e1013efb06a000b2f530f
Deploy Preview https://deploy-preview-23--prep-project-22-oct-1.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

akshitadixit commented 1 year ago

@kanchitank good luck reviewing the PR, feel free to ask for help if needed :)

akshitadixit commented 1 year ago

image

aku1310 commented 1 year ago

image

I only see one component folder in my system, and in all the repositories (main and forked), there are two of them :grimacing:

akshitadixit commented 1 year ago

@kanchitank please finish your review so we can have this merged :)

aku1310 commented 1 year ago

@kanchitank please check and let me know if it's working, If not I'll send you the API Key which might be causing the issue

Devansu-Yadav commented 1 year ago

As soon as I type an alphabet, I'm getting this: "Error: city not found" error in the deploy preview.

P.S. Sorry for the delay from my end.

Yes I noticed that the deploy preview is breaking. That's actually not due to our code. Actually, someone integrated a new API call(as there were a couple of PRs merged earlier 😅) but forgot to handle the API errors by setting the error state.

Check line no 121 in App.js, the data is fetched, but if the API does not return a 200 response, there's no code to handle the errors fetched from the API.

Edit: @kanchitank It seems like the API key for this newly integrated API has not been added over Netlify which might be causing the issue you were facing earlier. The API key still hasn't been added yet so it's still failing, but after @aku1310 's changes, seems like the App is not breaking any more.

Devansu-Yadav commented 1 year ago

@kanchitank please check and let me know if it's working, If not I'll send you the API Key which might be causing the issue

The API key has already been added @aku1310 for the API we integrated it's not because of that.