Closed niyoj closed 1 year ago
Name | Link |
---|---|
Latest commit | f0a254ded10267746cf62f067f99487dcdef9879 |
Latest deploy log | https://app.netlify.com/sites/prep-project-22-oct-1/deploys/6350c1e379a8aa00096e5fd3 |
Deploy Preview | https://deploy-preview-47--prep-project-22-oct-1.netlify.app/ |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
@akshitadixit we have created a PR that solves the issue #13 . Can you please merge it?
@amv2 can you review this PR as this is improved version of previous PR which you are reviewing.
@akshitadixit we think the deploy errors are there due to some environment variables missing in Netlify. Can you confirm this?
@niyoj here is a ss of the logs that might be helpful
@akshitadixit we have not made changes to any thing in Forecast.js
. So, we could not figure out the problem.
@amv2 can you review this PR as this is improved version of previous PR which you are reviewing.
Apologies @niyoj ! I saw the deploy before the checks failed and the changes looked good! I was just waiting for the checks to all pass before approving
No problem at all @amv2. Thanks for your review.
@akshitadixit the deploy errors have been fixed. Can you merge this PR?
What changes have been done?