MLH-Fellowship / prep-project-22.OCT.PREP.1

MLH Prep Project for Pod 22.OCT.PREP.1
https://prep-project-22-oct-1.netlify.app/
MIT License
2 stars 15 forks source link

Closes #13: adds dynamic map markers #47

Closed niyoj closed 1 year ago

niyoj commented 1 year ago

What changes have been done?

netlify[bot] commented 1 year ago

Deploy Preview for prep-project-22-oct-1 ready!

Name Link
Latest commit f0a254ded10267746cf62f067f99487dcdef9879
Latest deploy log https://app.netlify.com/sites/prep-project-22-oct-1/deploys/6350c1e379a8aa00096e5fd3
Deploy Preview https://deploy-preview-47--prep-project-22-oct-1.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

niyoj commented 1 year ago

@akshitadixit we have created a PR that solves the issue #13 . Can you please merge it?

niyoj commented 1 year ago

@amv2 can you review this PR as this is improved version of previous PR which you are reviewing.

niyoj commented 1 year ago

@akshitadixit we think the deploy errors are there due to some environment variables missing in Netlify. Can you confirm this?

akshitadixit commented 1 year ago

@niyoj here is a ss of the logs that might be helpful image

niyoj commented 1 year ago

@akshitadixit we have not made changes to any thing in Forecast.js. So, we could not figure out the problem.

MosesDVarghese commented 1 year ago

@amv2 can you review this PR as this is improved version of previous PR which you are reviewing.

Apologies @niyoj ! I saw the deploy before the checks failed and the changes looked good! I was just waiting for the checks to all pass before approving

niyoj commented 1 year ago

No problem at all @amv2. Thanks for your review.

niyoj commented 1 year ago

@akshitadixit the deploy errors have been fixed. Can you merge this PR?