search

MLH-Fellowship / prep-project-22.P3.1

MLH Prep Project for 22.P3.1
https://prep-22-p3-1-project.netlify.app
MIT License
10 stars 15 forks source link

Added Background music #54

Closed abhishekrawe closed 2 years ago

abhishekrawe commented 2 years ago

Added background music that changes dynamically according to the weather condition currently the background music is playing via onclick functionalities and I am working on finding the solution to autoplay the music.

netlify[bot] commented 2 years ago

Deploy Preview for prep-22-p3-1-project ready!

Name Link
Latest commit cab0fa35e06367535edf0d0d683a24ce5fe0b891
Latest deploy log https://app.netlify.com/sites/prep-22-p3-1-project/deploys/6262cad2dd1e7f0009113f5b
Deploy Preview https://deploy-preview-54--prep-22-p3-1-project.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

yashika51 commented 2 years ago

@abhishekrawe status on this? Have you added the changes regarding icon that we discussed yesterday?

abhishekrawe commented 2 years ago

Yes @yashika51 it's done ✅

abhishekrawe commented 2 years ago

Please review this issue @yashika51

abhishekrawe commented 2 years ago

It is Ready to Merge @yashika51, please merge it.

Mayank17M commented 2 years ago

@abhishekrawe I think you have some prettier errors that's why the build is failing. I can help you resolve them if you want.

yashika51 commented 2 years ago

We need to fix the errors and conflict first @abhishekrawe

yashika51 commented 2 years ago

@abhishekrawe status?

abhishekrawe commented 2 years ago

Resolved conflicts, @yashika51, ready to merge

yashika51 commented 2 years ago

@abhishekrawe yeah I would suggest keeping audio files in assets

Mayank17M commented 2 years ago

@yashika51 this is ready for merge.