MLH-Fellowship / prep-project-23.APR.PREP.1

MLH Prep Project for Pod 23.MAR.PREP.1
https://mlh-prep-23-apr-prep-1-project.netlify.app/
MIT License
7 stars 16 forks source link

Display 5-day forecast with daily 3-hour forecast view #15

Closed ttn-ttn closed 1 year ago

ttn-ttn commented 1 year ago

We have implemented a 5-day forecast with detailed daily view that fixes #1 . We decided to display the 5-day view instead of letting the user pick a day and hour because it's a better user experience (when clicking one of the days, the 3-hourly forecast for that day is displayed). We used the 5 day API because it's the one included in the free tier, but this could more or less easily be extended to use the 16 day (paid) API if we finally can use it.

We have implemented it as a Forecast component independent from the current weather display on App.js to avoid merge conflicts, as there is a lot of people already relying on the current weather API. It probably will make sense to fuse both into a single component in the future, after the yet-to-come PRs that rely on the current weather API have been merged.

@akshgpt7 this is ready for review and merging.

netlify[bot] commented 1 year ago

Deploy Preview for mlh-prep-23-apr-prep-1-project ready!

Name Link
Latest commit 64c275033fa7ce8e278133ad02a59af5f06281aa
Latest deploy log https://app.netlify.com/sites/mlh-prep-23-apr-prep-1-project/deploys/643e3232568a9000081161ce
Deploy Preview https://deploy-preview-15--mlh-prep-23-apr-prep-1-project.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

akshgpt7 commented 1 year ago

Damn! This looks awesome! Can you just fix the merge conflict and I'll merge it.

ttn-ttn commented 1 year ago

@akshgpt7 it should be good now