search

MLH-Fellowship / prep-project-23.APR.PREP.1

MLH Prep Project for Pod 23.MAR.PREP.1
https://mlh-prep-23-apr-prep-1-project.netlify.app/
MIT License
7 stars 16 forks source link

Update API #8

Closed ttn-ttn closed 1 year ago

ttn-ttn commented 1 year ago

Update from deprecated built-in geocoder API to using currently recommended geocoding API.

The documentation for the Openweathermap current weather API states:

Please use Geocoder API if you need automatic convert city names and zip-codes to geo coordinates and the other way around.

Please note that built-in geocoder has been deprecated. Although it is still available for use, bug fixing and updates are no longer available for this functionality.

Currently, the app uses the deprecated API. This PR updates the app to use the recommended geocoding API.

netlify[bot] commented 1 year ago

Deploy Preview for mlh-prep-23-apr-prep-1-project ready!

Name Link
Latest commit 05b6aa2179f6fd5e43f05f6cdafcdc36ad062f16
Latest deploy log https://app.netlify.com/sites/mlh-prep-23-apr-prep-1-project/deploys/64367a114acafe0008509828
Deploy Preview https://deploy-preview-8--mlh-prep-23-apr-prep-1-project.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

akshgpt7 commented 1 year ago

@ttn-ttn can you remove the default "New York City" in the search field? To enter a new place, we'll have to first remove that text.

ttn-ttn commented 1 year ago

No problem, however I think it may be better to wait and update the API later, because there are already many PRs relying on the deprecated API. It will be easier to make the change later than to make everyone update it now.