search

MLH-Fellowship / prep-project-4.1.1

MLH Prep Project for Pod 4.1.1
https://mlh-prep-4-1-1.netlify.app/
MIT License
6 stars 13 forks source link

Record previous searches #16

Closed ShiviPro closed 2 years ago

ShiviPro commented 2 years ago

Summary

I along with @Tanmay000009 have brainstormed about various ways through which #12 can be resolved. Currently, we're facing an issue with how searches function, which is blocking us from making a successful PR.

Details

The issue is that currently, each search happens when a change event is triggered on the input field. But with this keeping track of successful searches, and hence maintaining the list of several previous searches becomes difficult, because the API returns us a city, even if the current combination doesn't make up a valid one, since it returns the city which starts with that character sequence. This is preventing us from keeping an accurate track of the cities that users actually searched for.

Related issues

Also as we suggested here that issue #6 can use our data if the input fields are empty.

netlify[bot] commented 2 years ago

✔️ Deploy Preview for mlh-prep-4-1-1 ready!

🔨 Explore the source changes: fdedd7d87f3c82e5292318645b92cbcbeb0264c0

🔍 Inspect the deploy log: https://app.netlify.com/sites/mlh-prep-4-1-1/deploys/6168207fc6f53c0008ed6e7d

😎 Browse the preview: https://deploy-preview-16--mlh-prep-4-1-1.netlify.app/

ShiviPro commented 2 years ago

This PR was made last week in order for @khattakdev to track our progress on issue #12 and since that has been solved in another PR, I'm closing this.