Closed saikeshari closed 2 years ago
✔️ Deploy Preview for mlh-prep-4-1-3 ready!
🔨 Explore the source changes: 4a099e33de5d86c8cce87c95e833e5225b261e65
🔍 Inspect the deploy log: https://app.netlify.com/sites/mlh-prep-4-1-3/deploys/6199601cd835d900074bd7b5
😎 Browse the preview: https://deploy-preview-20--mlh-prep-4-1-3.netlify.app/
Please, fix conflicts
@grace-omotoso Can i look into the issue of loader mentioned by @sumana2001? I think I know how to fix it. If it will be fixed, there would no conflicts in this pull
please, fix conflict
@saikeshari Please, fix conflicts
Fixed the conflicts @grace-omotoso
@saikeshari Please, fix conflicts
@saikeshari please, fix conflict
@Young-Einstein10, please, review this PR
@saikeshari daily forecast cards appear too scanty. Can we have more content e.g
Also, can you add some effects to this cards.
On the main weather card, please, reduce the width and let us have current time displayed there
Hey, I'm unable to see changes in cards and map after changing name of city. Please check it once. @saikeshari
@saikeshari cards are not being updated when a new city is entered
Yes, I was working on that only. Actually, these changes were to be made at root of project in App.js and useWeather, so encountered many problems, had to also introduce a new API to get langitude and latitude from a place. Also due to this, I had to solve many merge conflicts. But finally done ✨
In the deploy, it is still not working. On my local machine, it works. Will update asap
@grace-omotoso Fixed it. Please review
@saikeshari please, remove all commented code
@saikeshari Apologies, please, fix conflict again
@saikeshari Please, can we get the local time on the main weather info card. If it will be a quick one, please, include that. Otherwise, we can have a separate issue. Just let me know.
@grace-omotoso Added the time in the main card. Please review.
Right now, it is displaying the time at which the request was made. If continuously changing current time would be more suitable, let me know. Will do that
Removed the commented code
@grace-omotoso Please review