MLH-Fellowship / prep-project-4.1.3

MLH Prep Project for Pod 4.1.3
https://mlh-prep-4-1-3.netlify.app/
MIT License
3 stars 10 forks source link

Daily and Hourly Forecast Closes Issue #1, #10 and #24 #20

Closed saikeshari closed 2 years ago

saikeshari commented 2 years ago

@grace-omotoso Please review

netlify[bot] commented 2 years ago

✔️ Deploy Preview for mlh-prep-4-1-3 ready!

🔨 Explore the source changes: 4a099e33de5d86c8cce87c95e833e5225b261e65

🔍 Inspect the deploy log: https://app.netlify.com/sites/mlh-prep-4-1-3/deploys/6199601cd835d900074bd7b5

😎 Browse the preview: https://deploy-preview-20--mlh-prep-4-1-3.netlify.app/

grace-omotoso commented 2 years ago

Please, fix conflicts

saikeshari commented 2 years ago

@grace-omotoso Can i look into the issue of loader mentioned by @sumana2001? I think I know how to fix it. If it will be fixed, there would no conflicts in this pull

grace-omotoso commented 2 years ago

please, fix conflict

grace-omotoso commented 2 years ago

@saikeshari Please, fix conflicts

saikeshari commented 2 years ago

Fixed the conflicts @grace-omotoso

grace-omotoso commented 2 years ago

@saikeshari Please, fix conflicts

grace-omotoso commented 2 years ago

@saikeshari please, fix conflict

grace-omotoso commented 2 years ago

@Young-Einstein10, please, review this PR

grace-omotoso commented 2 years ago

@saikeshari daily forecast cards appear too scanty. Can we have more content e.g

weekly forecast

Also, can you add some effects to this cards.

On the main weather card, please, reduce the width and let us have current time displayed there

GrayFlash commented 2 years ago

Screenshot from 2021-11-19 16-06-10

Hey, I'm unable to see changes in cards and map after changing name of city. Please check it once. @saikeshari

grace-omotoso commented 2 years ago

@saikeshari cards are not being updated when a new city is entered

saikeshari commented 2 years ago

Yes, I was working on that only. Actually, these changes were to be made at root of project in App.js and useWeather, so encountered many problems, had to also introduce a new API to get langitude and latitude from a place. Also due to this, I had to solve many merge conflicts. But finally done ✨

saikeshari commented 2 years ago

In the deploy, it is still not working. On my local machine, it works. Will update asap

saikeshari commented 2 years ago

@grace-omotoso Fixed it. Please review

grace-omotoso commented 2 years ago

@saikeshari please, remove all commented code

grace-omotoso commented 2 years ago

@saikeshari Apologies, please, fix conflict again

grace-omotoso commented 2 years ago

@saikeshari Please, can we get the local time on the main weather info card. If it will be a quick one, please, include that. Otherwise, we can have a separate issue. Just let me know.

saikeshari commented 2 years ago

@grace-omotoso Added the time in the main card. Please review.

saikeshari commented 2 years ago

Right now, it is displaying the time at which the request was made. If continuously changing current time would be more suitable, let me know. Will do that

saikeshari commented 2 years ago

Removed the commented code