Fixed loader spacing and displaying

MLH-Fellowship / prep-project-4.1.3

MLH Prep Project for Pod 4.1.3

https://mlh-prep-4-1-3.netlify.app/

MIT License

3 stars 10 forks source link

Fixed loader spacing and displaying #23

Closed OjusWiZard closed 3 years ago

OjusWiZard commented 3 years ago

Closes #13

netlify[bot] commented 3 years ago

✔️ Deploy Preview for mlh-prep-4-1-3 ready!

🔨 Explore the source changes: 41ae049dbc17a1f9248b5288e1c2e0bb851aa1df

🔍 Inspect the deploy log: https://app.netlify.com/sites/mlh-prep-4-1-3/deploys/61981ea0a93659000824703c

😎 Browse the preview: https://deploy-preview-23--mlh-prep-4-1-3.netlify.app/

grace-omotoso commented 3 years ago

@PriyaBihani Please, fix conflicts

OjusWiZard commented 3 years ago

@saikeshari PTAL

grace-omotoso commented 3 years ago

@PriyaBihani The loader is still in effect when the user types. The loader should only work when transitioning between pages and when refreshing or loading page. Please take a look at this. Thanks

OjusWiZard commented 3 years ago

@grace-omotoso Now it's showing the loader while the page is loading. But, haven't removed the loader when it's making the API call because it improves the UX, as the user gets the feedback that it's fetching the data from the API.