search

MLH-Fellowship / prep-project-4.1.4

MLH Prep Project for Pod 4.1.4
https://mlh-prep-4-1-4.netlify.app/
MIT License
2 stars 12 forks source link

Added Voice assistance #30

Open drishtipeshwani opened 2 years ago

drishtipeshwani commented 2 years ago

Fixed Issue #15

netlify[bot] commented 2 years ago

✔️ Deploy Preview for mlh-prep-4-1-4 ready!

🔨 Explore the source changes: 702025dbdd67602730ea6d25f5f610ca40373998

🔍 Inspect the deploy log: https://app.netlify.com/sites/mlh-prep-4-1-4/deploys/61a0fa476f382100078e7d75

😎 Browse the preview: https://deploy-preview-30--mlh-prep-4-1-4.netlify.app/

NoahCardoza commented 2 years ago

I know you are still waiting on reviews from @DinuBotan and @shravani05 but some of my recent PR's have caused some merge conflicts.

Also, I wasn't able to get the speech to text to work. Every time I clicked the mic icon, the slash would reappear a second or two after clicking it without clicking it a second time... does that make sense?

I'm using the Brave Browser on macOS and no errors occurred in the console.

However, after testing in Chrome it seems to work. I'd suggest either debugging on the Brave Browser or disabling the feature when !(navigator.brave && await navigator.brave.isBrave()).

It also might be a good idea to set the search bar after updating the card based on the user's speech.

image

drishtipeshwani commented 2 years ago

I know you are still waiting on reviews from @DinuBotan and @shravani05 but some of my recent PR's have caused some merge conflicts.

Also, I wasn't able to get the speech to text to work. Every time I clicked the mic icon, the slash would reappear a second or two after clicking it without clicking it a second time... does that make sense?

I'm using the Brave Browser on macOS and no errors occurred in the console.

However, after testing in Chrome it seems to work. I'd suggest either debugging on the Brave Browser or disabling the feature when !(navigator.brave && await navigator.brave.isBrave()).

It also might be a good idea to set the search bar after updating the card based on the user's speech.

image

Yaa, I should have taken care of supported browsers. These are the supported browsers -

drishtipeshwani commented 2 years ago

Ya, I changed that. I added a function to get the coordinates of the city that we will speak and I am setting those coordinates. So able to fetch the correct data. However, I am not sure how to update the search bar because it is an Autocomplete component so you can set a default value at the beginning but not sure if we can change the value. Any idea about this?

drishtipeshwani commented 2 years ago

However, the name of the place of the weather card is showing different, that issue has been fixed by Pratyush in the previous PR.

NoahCardoza commented 2 years ago

If you don't have any luck with this I can try looking for a solution tomorrow.

Also, the voice button still seems to show up in Brave (and not work). Maybe the little code snippet I gave you was bad?

drishtipeshwani commented 2 years ago

Ya actually the npm library that I am using for this had a function to see if the current browser is supported or not, so I used that and it was working as Firefox is not a supported browser so it was not showing the microphone, not sure why it is not happening with Brave. I will put the condition you gave and see

drishtipeshwani commented 2 years ago

The only thing remaining is to update the search bar with that place name, but I am not able to understand how to change the value as it is an Autocomplete component and has only a default value parameter.

drishtipeshwani commented 2 years ago

Does everything look good now ?