Closed Pratyush1606 closed 2 years ago
✔️ Deploy Preview for mlh-prep-4-1-4 ready!
🔨 Explore the source changes: 49b719a3eadd4d3882377c662f67e8f045ec1394
🔍 Inspect the deploy log: https://app.netlify.com/sites/mlh-prep-4-1-4/deploys/61a0f4d63155a70007bff2f5
😎 Browse the preview: https://deploy-preview-33--mlh-prep-4-1-4.netlify.app/
@Pratyush1606 LGTM
It seems like this feature it's working for me on macOS Chrome:
@NoahCardoza Are you talking about the preview of this pr or the main one?
@NoahCardoza Are you talking about the preview of this pr or the main one?
Maybe I'm not clear on what this PR does. I expected it would make sure the city name in the search bar matched the name in the card:
In this image the card says "San Jose" but the search bar says "New York".
However, after rereading your description, maybe that's wasn't within the scope of your PR?
@NoahCardoza yes right, this pr just detects location using geolocation api
LGTM, just a small merge conflict.
@NoahCardoza Resolved the conflict :)
Fixes #32
Actually, in Pull Request #17, the geolocation is setting
city
and then using that value for displaying the corresponding weather. But in the merged version,cityCoordinates
is being used to get the result.In #17,
fetch( "https://api.openweathermap.org/data/2.5/weather?q=" + city + "&units=metric" + "&appid=" + process.env.REACT_APP_APIKEY )
In the current main version,
fetch( "https://api.openweathermap.org/data/2.5/weather?lat=" + cityCoordinates.lat + "&lon=" + cityCoordinates.lon + "&units=metric" + "&appid=" + process.env.REACT_APP_APIKEY )