This task is part of a bigger effort to migrate Pytorch from Mypy to Pyre. The goal of this task for you is to gain comfort with the Python type system and the types of errors Pyre gives. Future Pysa project work and debugging builds on this foundation.
Fix the Pyre type checking errors in torch/fx/node.py:
torch/fx/node.py:363:20 Incompatible variable type [9]: placeholder_names is declared to have type `List[str]` but is used as type `None`.
torch/fx/node.py:364:20 Incompatible variable type [9]: maybe_return_typename is declared to have type `List[str]` but is used as type `None`.
Submitting a PR
We use the following linters internally, so to save everyone's time, please make sure you run the following linters locally and fix errors related to the files you modified before submitting a PR:
black && usort format . && flake8
To install the linters, you can run the following command:
This task is part of a bigger effort to migrate Pytorch from Mypy to Pyre. The goal of this task for you is to gain comfort with the Python type system and the types of errors Pyre gives. Future Pysa project work and debugging builds on this foundation.
Development Environment Setup
Task Description
Fix the Pyre type checking errors in
torch/fx/node.py:Submitting a PR
We use the following linters internally, so to save everyone's time, please make sure you run the following linters locally and fix errors related to the files you modified before submitting a PR:
To install the linters, you can run the following command: