MLH-Fellowship / pyre-check

Performant type-checking for python.
https://pyre-check.org/
MIT License
3 stars 1 forks source link

[Fall 2021] Step 3: Automate Pysa Quickstart guide for new users to quickly initialize a environment for Pysa #80

Closed 0xedward closed 3 years ago

0xedward commented 3 years ago

Automate the steps in the Quickstart and add some logic to automatically handle and fix some common issues, so the automation is completed, the user has their environment set up to run Pysa (pyre analyze)

Feel free to pick whatever automation method (e.g. script, ansible, etc.) you think is best :)

Submitting a PR

We use the following linters internally, so to save everyone's time, please make sure you run the following linters locally and fix errors related to the files you modified before submitting a PR:

black && usort format . && flake8

To install the linters, you can run the following command:

pip install flake8 usort black==21.4b2
abishekvashok commented 3 years ago

Claiming this one!

abishekvashok commented 3 years ago

Just to be sure, @0xedward , is this only about:

Or did I miss anything?

0xedward commented 3 years ago

Ah I think pyre init has some logic to set up taint_models_path. If the user has a venv activated, I think by default it sets the path to {venv_path}/lib/

Sorry I'm realizing now that this issue might be better as a script instead of a built-in command in Pyre, since the goal of the issue was to automate the setup steps in the Quickstart guide and have some automatic error handling for common issues people run into. I'll update the issue to better describe this

abishekvashok commented 3 years ago

Closed via https://github.com/facebook/pyre-check/commit/e7d5d7576d4829a6f01c81962f368d317ad09472