search

MLH-Fellowship / react-native-tutorial

6 stars 0 forks source link

Set up the directory #17

Closed XifeiNi closed 3 years ago

XifeiNi commented 3 years ago

This PR creates the basic project structure by the following command: npx react-native init nonCisMaleInCs

To run this project, firstly start Metro in nonCisMaleInCs/ folder by npx react-native start If you use the Yarn package manager, you can use yarn instead of npx when running React Native commands inside an existing project. Letting metro run in its own terminal, open up a new terminal and follow here to run ios and android respectively

StuffByLiang commented 3 years ago

LGTM!! although I feel like the root directory should be the folder nonCisMaleInCs instead? What do you think?

princiya commented 3 years ago

👍 first PR 🎉 thank you @XifeiNi . let's merge this, and when we see if something is not required, we can update files in follow up PRs.

princiya commented 3 years ago

@XifeiNi please also mention in this PR how did you setup this project, for example which commands. 🙏

XifeiNi commented 3 years ago

LGTM!! although I feel like the root directory should be the folder nonCisMaleInCs instead? What do you think?

Actually have considered this. I think the react-native-tutorial directory should have documentation and the miniApp. Hence the nonCisMaleInCs resides inside the folder.

XifeiNi commented 3 years ago

@XifeiNi please also mention in this PR how did you setup this project, for example which commands. 🙏

Thanks for picking this up! Done