search

MLH-Fellowship / react-native-tutorial

6 stars 0 forks source link

Details view page #24

Closed temitopeakinsoto closed 3 years ago

temitopeakinsoto commented 3 years ago

issue #22

*Create the detailed view component for the tutorial app*

Description: This PR creates the details view for the tutorial app as contained in the mock up design file.

princiya commented 3 years ago

@temitopeakinsoto just some minor things to be fixed, but otherwise thank you for creating this PR really quick 👏

temitopeakinsoto commented 3 years ago

@princiya All requested changes have been implemented. Feel free to request additional changes. Thank You.

PragatiVerma18 commented 3 years ago

Screenshot

We can improve a little on the styles, the picture should have some margin from the header to be displayed correctly. We should also go for better icons.

Moreover, I saw some linting errors, please run npm run lint -- --fix to fix them up.

princiya commented 3 years ago

@PragatiVerma18 thank you for your review.

@temitopeakinsoto would be nice to fix those margin issues.

@PragatiVerma18

We should also go for better icons.

do you have something in mind for this? If not, we can leave it the way it is now and can improvise the design later.

temitopeakinsoto commented 3 years ago

I added a few changes to the photo image and touched up the design a tiny bit. Kindly review. Thanks

On Mon, Nov 30, 2020, 6:12 PM Princiya Marina Sequeira < notifications@github.com> wrote:

@PragatiVerma18 https://github.com/PragatiVerma18 thank you for your review.

@temitopeakinsoto https://github.com/temitopeakinsoto would be nice to fix those margin issues.

@PragatiVerma18 https://github.com/PragatiVerma18

We should also go for better icons.

do you have something in mind for this? If not, we can leave it the way it is now and can improvise the design later.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MLH-Fellowship/react-native-tutorial/pull/24#issuecomment-735919743, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALY7B22U5QDZMGXURZRAPFTSSPG7FANCNFSM4UEZ3WLQ .

princiya commented 3 years ago

@temitopeakinsoto let's merge the PR? or are you gathering inputs from @XifeiNi ?

temitopeakinsoto commented 3 years ago

@temitopeakinsoto let's merge the PR? or are you gathering inputs from @XifeiNi ?

@princiya Yes, I was gathering inputs from @XifeiNi.

@temitopeakinsoto let's merge the PR? or are you gathering inputs from @XifeiNi ?