search

MLH-Fellowship / sapp

Post Processor for Facebook Static Analysis Tools.
MIT License
1 stars 0 forks source link

Add proper syntax highlighting support for Java in Web UI for MT issues #5

Closed 0xedward closed 3 years ago

0xedward commented 3 years ago

Steps to Reproduce:

  1. Download the zip of a SAPP db containing the MT run to help you reproduce the issue and the source code of what MT was run on

  2. Extract both zip files and run the following command to get started looking into this in SAPP

    python3 -m sapp.cli --database-name sapp.db --source-directory repo/ --debug

  3. Visit http://localhost:3000 and click on Issue 1 in Run 1 image

  4. Notice that reserved words (e.g. public) and return types (e.g. void) aren't highlighted, while other syntax that doesn't seem important in Java (e.g. from: in the comment line) is highlighted image

Expected result:

For each trace frame for MT issues, the code displayed has Java reserved words highlighted and no irrelevant syntax highlighted

abishekvashok commented 3 years ago

Fixed via https://github.com/facebook/sapp/pull/47

abishekvashok commented 3 years ago

closed via https://github.com/facebook/sapp/commit/b1c6f980c8f27c2f0e2d3bb04d82c088dfad371a