search

MLH-Fellowship / scheduling-profiler-prototype

Custom profiler prototype for React's concurrent mode
https://react-scheduling-profiler.vercel.app/
6 stars 0 forks source link

[Improve base View][3/n] Add _ to views' private vars and methods #101

Closed taneliang closed 4 years ago

taneliang commented 4 years ago

Stack PR by STACK ATTACK:

Our classes have many private vars and methods. As JS classes don't have private methods and vars yet (I don't believe React has enabled transpilation of the new # syntax), I've followed existing JS convention and prefixed them with _s.

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mlh-fellowship/scheduling-profiler-prototype/opir3eo3b ✅ Preview: https://scheduling-profiler-prototype-git-5f2da-2.mlh-fellowship.vercel.app