search

MLH-Fellowship / scheduling-profiler-prototype

Custom profiler prototype for React's concurrent mode
https://react-scheduling-profiler.vercel.app/
6 stars 0 forks source link

fix: text link transition #104

Closed vikashchander closed 4 years ago

vikashchander commented 4 years ago

hi,

try to fix Import page link text animates at a different speed compared to the rest of the page's text #65

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mlh-fellowship/scheduling-profiler-prototype/emy46niwe ✅ Preview: https://scheduling-profiler-prototype-git-fork-vikashchander-vikash.mlh-fellowship.vercel.app

kartikcho commented 4 years ago

Is there a way to keep the hover transitions and fixing the text resize speed without removing them at all? Can you look into it if possible @vikashchander ?

vikashchander commented 4 years ago

Is there a way to keep the hover transitions and fixing the text resize speed without removing them at all? Can you look into it if possible @vikashchander ?

yeah, I can try through changing value of transitions

kartikcho commented 4 years ago

yeah, I can try through changing value of transitions

That would still cause the issue to persist, just faster. Maybe there's a specific way around this you might want to look into.

vikashchander commented 4 years ago

yeah, I can try through changing value of transitions

That would still cause the issue to persist, just faster. Maybe there's a specific way around this you might want to look into.

could you suggest me any specific way ??

kartikcho commented 4 years ago

Looks good, could you rename your branch to text-animation-fix. Also as a future note, don't name your branch as your name. Let's get this merged soon!