Closed taneliang closed 4 years ago
I'll decrease the bar's height tomorrow. @kartikcho I'd appreciate it if you could approve this PR first so that I can land everything tomorrow morning :)
This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/mlh-fellowship/scheduling-profiler-prototype/48r57zsok ✅ Preview: https://scheduling-profiler-prototyp-git-sttack-architecto-cumqu-10b758.mlh-fellowship.vercel.app
Decreased bar height by 1px (it's now 5px tall) and rebased on master
Stack PR by STACK ATTACK:
110 [Resize content][1/n] Break horizontal scrolling area into final-ish hierarchy
108 [Resize content][3/n] Sync horizontal pan and zoom states
109 Implement User Timing marks view
111 Highlight React events with the same wakeable ID
Summary
Implements
ResizableSplitView
and uses it to allow resizing of the React measures view.This PR also fixes the last PR's known issue where the flamechart does not scroll vertically.
Resolves #19, resolves #70.
Test Plan
yarn lint
yarn flow
: no errors in changed codeyarn test
: no added tests, but everything still passesyarn start
: manual testing:There are still 3 independent horizontal pan/zoom areas, a known issue carried over from the last PR in this stack. This will be fixed in the next PR (#108).