MLH-Fellowship / scheduling-profiler-prototype

Custom profiler prototype for React's concurrent mode
https://react-scheduling-profiler.vercel.app/
6 stars 0 forks source link

[Resize content][2/n] Implement ResizableSplitView #107

Closed taneliang closed 4 years ago

taneliang commented 4 years ago

Stack PR by STACK ATTACK:

Summary

Implements ResizableSplitView and uses it to allow resizing of the React measures view.

This PR also fixes the last PR's known issue where the flamechart does not scroll vertically.

Resolves #19, resolves #70.

Test Plan

There are still 3 independent horizontal pan/zoom areas, a known issue carried over from the last PR in this stack. This will be fixed in the next PR (#108).

taneliang commented 4 years ago

I'll decrease the bar's height tomorrow. @kartikcho I'd appreciate it if you could approve this PR first so that I can land everything tomorrow morning :)

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mlh-fellowship/scheduling-profiler-prototype/48r57zsok ✅ Preview: https://scheduling-profiler-prototyp-git-sttack-architecto-cumqu-10b758.mlh-fellowship.vercel.app

taneliang commented 4 years ago

Decreased bar height by 1px (it's now 5px tall) and rebased on master

image