[Resize content][1/n] Break horizontal scrolling area into final-ish hierarchy - Githubissues

MLH-Fellowship / scheduling-profiler-prototype

Custom profiler prototype for React's concurrent mode

https://react-scheduling-profiler.vercel.app/

6 stars 0 forks source link

[Resize content][1/n] Break horizontal scrolling area into final-ish hierarchy #110

Closed taneliang closed 4 years ago

taneliang commented 4 years ago

Stack PR by STACK ATTACK:

#110 [Resize content][1/n] Break horizontal scrolling area into final-ish hierarchy
107 [Resize content][2/n] Implement ResizableSplitView
108 [Resize content][3/n] Sync horizontal pan and zoom states
109 Implement User Timing marks view
111 Highlight React events with the same wakeable ID

Summary

This PR begins a PR stack that implements the resize of the lanes area.

In this PR, the view hierarchy is overhauled to more closely resemble the final one. This is the new view hierarchy:

View (vertically stacked layout) (root view)
- HorizontalPanAndZoomView
- View (vertically stacked layout)
  - TimeAxisMarkersView
  - ReactEventsView
- View (vertically stacked layout) (to be replaced with ResizableVerticalSplitView)
- HorizontalPanAndZoomView
  - VerticalScrollView
  - ReactMeasuresView
- HorizontalPanAndZoomView
  - VerticalScrollView
  - FlamechartView

This PR must be landed with the PRs stacked above it in order not to break master.

Test Plan

yarn lint
yarn flow: no errors in changed code
yarn test

Known issues

There are now 3 independent horizontal pan/zoom areas. This is intentional; it'll be fixed in a future PR in this stack (#108).
Flamechart no longer scrolls vertically. This will be fixed in a future PR in this stack (#107).