MLH-Fellowship / scheduling-profiler-prototype

Custom profiler prototype for React's concurrent mode
https://react-scheduling-profiler.vercel.app/
6 stars 0 forks source link

Show User Timing measures in the UI #112

Open taneliang opened 4 years ago

taneliang commented 4 years ago

Follows up from #72, which implemented User Timing marks but not measures.

Iterations

Iteration 1 was #72, which added User Timing marks.

Iteration 2: highlight a User Timing measure's marks together when one is hovered

This is a similar idea to #44. When a measure's start/end mark is hovered over, we can highlight its corresponding mark.

Steps

There are multiple ways to implement this; I'm thinking that the easiest way will be to implement something similar to suspense wakeable IDs (more context at #44), so that we can reuse the rendering logic.

Acceptance Criteria

Iteration 3: display User Timing measures

This is much trickier than the above 2 iterations, as this requires a variable number of rows (or 1 variable-height row) whereas the above 2 only require a fixed-height row.

The end result should be something similar to a combination of our React measures and the Chrome Performance tab's Timings section (screenshot below).

image

Acceptance Criteria