search

MLH-Fellowship / scheduling-profiler-prototype

Custom profiler prototype for React's concurrent mode
https://react-scheduling-profiler.vercel.app/
6 stars 0 forks source link

Switch to concurrent React #122

Closed taneliang closed 4 years ago

taneliang commented 4 years ago

Since we intend to move this project into the React codebase, I figured it'll be a good idea to upgrade us to React experimental and enable concurrent mode. This should ensure that we're closer to React master and reduce the chance of any unlikely integration issues.

Stacked on top of #121, because #121 includes fixes to ensure that the canvas is drawn together with React's commit phase, preventing the tooltip from lagging behind the canvas drawing when concurrent mode is enabled (a disorienting UX).

Also results in a qualitatively smoother scrolling experience (working towards #50 again). By some eyeball estimating, it looks like this PR is getting frame rates in the mid-to-high 20s, whereas #121 is getting around 19-20 FPS when scrolled to the same place.

Test Plan

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mlh-fellowship/scheduling-profiler-prototype/qrn2g06pr ✅ Preview: https://scheduling-profiler-prototype-git-eliang-concurrent-mode.mlh-fellowship.vercel.app

taneliang commented 4 years ago

Vercel not deploying. Closing and reopening to kick it

taneliang commented 4 years ago

Deployed but the bot is not updating: https://scheduling-profiler-prototype-git-eliang-concurrent-mode.mlh-fellowship.vercel.app/