Reimplement zoom to batch

MLH-Fellowship / scheduling-profiler-prototype

Custom profiler prototype for React's concurrent mode

https://react-scheduling-profiler.vercel.app/

6 stars 0 forks source link

Reimplement zoom to batch #123

Closed taneliang closed 4 years ago

taneliang commented 4 years ago

Closes #84.

Adds a zoomToRange method to HorizontalPanAndZoomView, modeled after UIScrollView's zoomToRect:animated: method

Test Plan

yarn flow: no new errors
CI
yarn start:

I suspect there's a bug in our batch duration calculation, because the zoom to method often zooms to an empty space. This is not a bug in the zooming: the view is zoomed to a range that matches the batch duration displayed in the tooltip. I'll file an issue for this tomorrow.

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mlh-fellowship/scheduling-profiler-prototype/ha3bwg861 ✅ Preview: https://scheduling-profiler-prototype-git-eliang-zoom-to-batch.mlh-fellowship.vercel.app