MLH-Fellowship / scheduling-profiler-prototype

Custom profiler prototype for React's concurrent mode
https://react-scheduling-profiler.vercel.app/
6 stars 0 forks source link

[Import Prep][7/n] Fix indeterministic test mark ordering #127

Closed taneliang closed 4 years ago

taneliang commented 4 years ago

Stack PR by STACK ATTACK:

yarn test sometimes fails when the output array has a different order. This order seems to be determined by the OS, and is not completely random. I'm not sure what the exact cause is, but I suspect that this is happening because the 2 marks have equal timestamps. This PR changes the timestamps such that they're different.

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mlh-fellowship/scheduling-profiler-prototype/oalwh683y
✅ Preview: https://scheduling-profiler-proto-git-stack-attack-underline-hom-dabcb6.mlh-fellowship.vercel.app

taneliang commented 4 years ago

@stackattack rebase

taneliang commented 4 years ago

@stackattack land

stack-attack-bot[bot] commented 4 years ago

Oops, we can't land closed PRs.