MLH-Fellowship / scheduling-profiler-prototype

Custom profiler prototype for React's concurrent mode
https://react-scheduling-profiler.vercel.app/
6 stars 0 forks source link

UX Overhaul, add user guide #135

Closed kartikcho closed 4 years ago

kartikcho commented 4 years ago

Resolves #125

Changes made in this PR

Screenshots:

image

image

We should update the explanations if they're not clear enough. Also, the legend keys look out of place in my opinion, we should think of a better layout. Maybe add another image explaining resize bar and scroll?

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mlh-fellowship/scheduling-profiler-prototype/qctzjq752
✅ Preview: https://scheduling-profiler-prototype-git-ux-overhaul.mlh-fellowship.vercel.app

kartikcho commented 4 years ago

What do you think about using labelled images like below?

lanes

taneliang commented 4 years ago

Cool! First impressions:

legend keys look out of place in my opinion

Yep, I agree

What do you think about using labelled images like below?

That looks okay, but we need to explain what React measures are

kartikcho commented 4 years ago

Could we left-align the text instead?

Sure

The text animates in 2 phases

It's because of the 'lazy' transition when overlay is loaded, not really an issue.

Could we move the images above the text in those situations?

Changed layout to single column, removed event legend key, moved images below text though.

image