Closed taneliang closed 4 years ago
This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/mlh-fellowship/scheduling-profiler-prototype/day54m8b4 ✅ Preview: https://scheduling-profiler-prototype-git-0f8a7-1.mlh-fellowship.vercel.app
Stack PR by STACK ATTACK:
89 Fix lint failure from #88
91 [Optimize flamechart][2/4] Replace Speedscope types with custom stack frame type
92 [Optimize flamechart][3/4] Rename flame graph -> flame chart
93 [Optimize flamechart][4/4] Split FlamechartView into row views
Summary
This commit begins a stack of PRs that optimizes our flamechart. Broadly, we need to replace the use of Speedscope's flamechart types with our own types that are optimized for our rendering code.
As flamechart was always moved around together with ReactProfilerData, it makes sense to move flamechart into it. That also necessitates moving preprocessFlamechart into preprocessData.
This PR works towards #50.
Test Plan
yarn flow
: errors present, but no errors in affected code.yarn lint
yarn start