Closed taneliang closed 4 years ago
This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.
š Inspect: https://vercel.com/mlh-fellowship/scheduling-profiler-prototype/cx4f68a6z ā Preview: https://scheduling-profiler-prototype-git-0f8a7-4.mlh-fellowship.vercel.app
Holding off on merging this due to these 2 known issues:
Lines appear between flamechart stack layer rows when the browser is zoomed in (https://github.com/MLH-Fellowship/scheduling-profiler-prototype/pull/96#issuecomment-665473507)
Flamechart view no longer expands to fill all available space, leaving a black area at the bottom.
Update: The issue is still observable when zoomed out.
I can't repro this when zoomed out. Is your screen a hidpi screen?
I can't repro this when zoomed out. Is your screen a hidpi screen?
Yes but that shouldn't be the issue here I think.
that shouldn't be the issue here I think.
You may be right. Without zooming in, I can't repro this on my Mac that has a HiDPI screen either.
I'll fix this tomorrow
I'll fix this tomorrow
I lied, this should be fixed. @kartikcho could you see if you still see this issue?
Okay nevermind I caused a zooming bug. I'll fix this tomorrow.
I'll fix this tomorrow.
I lied again, it's fixed š I accidentally wrote .x
instead of .y
. @kartikcho could you check again if you can still repro the issue you brought up?
Seems fixed as I can't repro it anymore, good job!
Stack PR by STACK ATTACK:
89 Fix lint failure from #88
90 [Optimize flamechart][1/4] Add flamechart to ReactProfilerData
91 [Optimize flamechart][2/4] Replace Speedscope types with custom stack frame type
92 [Optimize flamechart][3/4] Rename flame graph -> flame chart
Summary
Allow the view system to render only affected flamechart rows. This greatly improves flamechart hover performance, which has a high impact on our app's performance as the flamechart is the slowest view to render.
Also adds a new
ColorView
view that fills the flamechart area with a solid background color to fix these issues:visibleArea
s are all integers.Related to #50.
Test Plan
yarn flow
: no errors in changed codeyarn lint
yarn start
: 60 FPS hovers on our Facebook.com profileyarn test