Closed taneliang closed 4 years ago
This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/mlh-fellowship/scheduling-profiler-prototype/h5ssiarea ✅ Preview: https://scheduling-profiler-prototype-git-5f2da-0.mlh-fellowship.vercel.app
Stack PR by STACK ATTACK:
100 [Improve base View][2/n] Rationalize view layout system
101 [Improve base View][3/n] Add _ to views' private vars and methods
102 [Improve base View][4/n] Write tests for geometry.js
Stacked on #96.
Summary
This PR begins a stack of PRs that improves the base
View
class implemented in #80.This PR adds subview management to
View
, as there was a lot of duplicated subview handling code present in almost all ourView
subclasses. This also brings us closer to UIKit'sUIView
, which also handles its own subviews.Resolves #95.
Test Plan
yarn start
: nothing brokenyarn lint
yarn flow
: no errors in affected codeyarn test