MLH-Fellowship / scheduling-profiler-prototype

Custom profiler prototype for React's concurrent mode
https://react-scheduling-profiler.vercel.app/
6 stars 0 forks source link

[Improve base View][1/n] Add subview handling to View #99

Closed taneliang closed 4 years ago

taneliang commented 4 years ago

Stack PR by STACK ATTACK:

Stacked on #96.

Summary

This PR begins a stack of PRs that improves the base View class implemented in #80.

This PR adds subview management to View, as there was a lot of duplicated subview handling code present in almost all our View subclasses. This also brings us closer to UIKit's UIView, which also handles its own subviews.

Resolves #95.

Test Plan

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mlh-fellowship/scheduling-profiler-prototype/h5ssiarea ✅ Preview: https://scheduling-profiler-prototype-git-5f2da-0.mlh-fellowship.vercel.app