search

MLH / mlh-hackathon-flask-starter

Hackathon starter project for Flask applications
MIT License
731 stars 286 forks source link

Guide updates #25

Closed simyilin closed 2 years ago

simyilin commented 3 years ago

Hello! While going through the tutorial docs, I thought that some of these may be helpful:

Let me know what you think! Thanks for the tutorial! :)

WorkInProgress-Development commented 3 years ago

Reviewing is disabled, so I'll do it as a message: all changes seem good to me, except I'm not sure whose heroku link that is, I can't find any reference to it anywhere else. I'm not a MLH team member, but I'd be a little concerned that someone might end up being charged for that service.

simyilin commented 3 years ago

Thanks!! Got it. It's actually the link I found from the demo button here: https://hack.mlh.io/learn/ Would you happen to know what the link is supposed to be? It's for the 'service in action' link here: https://github.com/MLH/mlh-hackathon-flask-starter/blob/master/docs/USER_GUIDE.md#fetching-data If not I could probably leave it as it is and revert to the original.

sowmiyeh commented 3 years ago

Link to explanation about database connection URL format: https://flask-sqlalchemy.palletsprojects.com/en/2.x/config/#connection-uri-format is redirecting to 404 error page, it should be http

simyilin commented 3 years ago

Got it. I've changed both links from https to http://flask-sqlalchemy.palletsprojects.com/en/2.x/config/#connection-uri-format

Also, the original 'service in action' link points to here (https://github.com/MLH/mlh-hackathon-flask-starter/blob/master/app/controllers/github.py) so I'm wondering if the updated link could be this (https://github.com/MLH/mlh-hackathon-flask-starter/blob/master/app/services/github.py)?