DEV-688 update oauth gems

MLH / omniauth-mlh

OmniAuth strategy for MyMLH V3.

https://my.mlh.io/docs

MIT License

7 stars 8 forks source link

DEV-688 update oauth gems #8

Closed jeremygottfried closed 1 year ago

jeremygottfried commented 1 year ago

Changes:

Ruby 2.24 -> 2.7.5
oauth2 -> 2.0.9
omniauth -> 2.1.1
omniauth-oauth2 -> 1.8.0
authorize_path renamed to authorize_url
token_path renamed to token_url
/ from relative urls automatically handled by oauth2

theycallmeswift commented 1 year ago

LGTM!

theycallmeswift commented 1 year ago

Here's a gist to test it locally. Confirmed it is working as expected with the current updates: https://gist.github.com/theycallmeswift/d8a8a22f95dd5d35f03661b19665e0d3

jeremygottfried commented 1 year ago

Here's a gist to test it locally. Confirmed it is working as expected with the current updates: https://gist.github.com/theycallmeswift/d8a8a22f95dd5d35f03661b19665e0d3

@theycallmeswift I tried your gist with ruby 3.0.5, and it seems to return the correct redirect_uri in the url query params, but it says "not valid" on the view so I'm not sure which I'm supposed to pay attention to.

jeremygottfried commented 1 year ago

@theycallmeswift ok looks like ruby v3.0.5 is working with the gist. I'm bumping gem version to 1.0.0