search

MLMI2-CSSI / foundry

Simplifying the discovery and usage of machine-learning ready datasets in materials science and chemistry
MIT License
80 stars 16 forks source link

investigate GHA test failures #385

Closed ascourtas closed 1 year ago

ascourtas commented 1 year ago

Need to resolve. Perhaps need to fix our globus sdk package bounds? https://github.com/MLMI2-CSSI/foundry/actions/runs/5479160610/jobs/9980623198?pr=384

Also previously there was an error in tests with auth and search -- worth investigating if it comes up

blaiszik commented 1 year ago

I wrote this in Slack, but these tests also fail locally with older versions of the Globus SDK. So there is likely something else that we changed that is breaking the tests. We should look at any changes to the test files since last successful run perhaps.

ascourtas commented 1 year ago

TODO: check if this is still an issue at all, may have been resolved

ascourtas commented 1 year ago

i believe this has been resolved; closing until further notice