MLTSHP / mltshp

Source for the application that runs mltshp.com
https://mltshp.com/
Mozilla Public License 2.0
50 stars 21 forks source link

User Shake Endpoint Always Returns Shake Owner as File Owner #589

Open spaceninja opened 4 years ago

spaceninja commented 4 years ago

When loading posts for a user shake, the posts returned always have the owner of the file set to the user, rather than the actual uploader of the file.

Reproduction Steps:

Visit https://mltshp-vue.now.sh/shake/user/spaceninja and see the console for API responses.

spaceninja commented 4 years ago

Ah, I see the problem now. When you save an image to your shake, it's not pointing to the original sharekey, it's a new, reposted version with it's own sharekey.

Example:

original: https://mltshp.com/p/1I07K repost: https://mltshp.com/p/1I0ES

The original and the repost have different view counts, save counts, and comments.

So the problem is not that the API is reporting the wrong owner, the problem is that the API doesn't expose the original poster. You can see on MLTSHP.com the little "originally posted by everichon" footnote on my repost.

I suppose adding an originalOwner object to the returned file would be ideal.

spaceninja commented 1 year ago

Ideally, the API would be amended to include the following information for reposts: